[netperf-talk] OK, this time I really mean it?-)

[Andrew Gallatin]

Rick Jones wrote:
> So, I believe I have the last Windows tweaks from my windows contacts, and I 
> think we've gone long enough between releases of netperf that we have more than 
> enough fixes piled-up so I would like to declare netperf 2.4.5.  To that end I 
> need your help - please pull the current top-of-trunk and give it a try on your 
> platform of choice and let me know if anything is wrong in the next couple days.

Two very minor things:

1) When building svn using Ubuntu 8.04 as the "autotools" host,
    AND when building outside the tree, I get a problem with
    netperf_version.h not being created.  Eg:

svn co <....>
cd trunk
mkdir build.804
cd build.804
../configure
make

gcc -DHAVE_CONFIG_H -I. -I/home/gallatin/netperf/2.2-svn/trunk/src -I.. 
     -g -
O2 -MT netsh.o -MD -MP -MF .deps/netsh.Tpo -c -o netsh.o 
/home/gallatin/netperf/
2.2-svn/trunk/src/netsh.c
/home/gallatin/netperf/2.2-svn/trunk/src/netsh.c: In function 
'scan_cmd_line':
/home/gallatin/netperf/2.2-svn/trunk/src/netsh.c:929: error: 
'NETPERF_VERSION' u
ndeclared (first use in this function)
/home/gallatin/netperf/2.2-svn/trunk/src/netsh.c:929: error: (Each 
undeclared id
entifier is reported only once
/home/gallatin/netperf/2.2-svn/trunk/src/netsh.c:929: error: for each 
function i
t appears in.)

Somehow, it just copied netperf_version.h.in, rather than
actually doing what its supposed to.   I've never seen this
bug with local projects, so I'm guessing its something in
netperf, though I don't know what..  Have I mentioned how
much I love autotools??

2) Netperf on older Solaris (like S10GA) whines:

   WARNING! getaddrinfo returned a protocol other than the
   requested protocol.  Please contact your vendor for
   a fix to this bug in getaddrinfo()

There's nothing I can do about it, I didn't write the OS,
and I hate having my output cluttered with seemingly
useless noise.  Can we please make these conditional
on debugging?   Proposed patch attached.

Thanks,

Drew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: warn.diff
Type: text/x-diff
Size: 352 bytes
Desc: not available
Url : http://www.netperf.org/pipermail/netperf-talk/attachments/20090603/5683f0af/attachment.diff