[netperf-dev] netperf2 commit notice r510 - in trunk: . src

[raj at netperf.org]

Author: raj
Date: 2011-12-02 10:46:32 -0800 (Fri, 02 Dec 2011)
New Revision: 510

Modified:
   trunk/AUTHORS
   trunk/src/nettest_omni.c
Log:
it is poor form to access beyond the bounds of an array

Modified: trunk/AUTHORS
===================================================================
--- trunk/AUTHORS	2011-12-01 22:55:19 UTC (rev 509)
+++ trunk/AUTHORS	2011-12-02 18:46:32 UTC (rev 510)
@@ -268,4 +268,7 @@
 Cleanups for the manual.
 
 Amir Vidai
-Patch from which changes to set SO_PRIORITY were based.
\ No newline at end of file
+Patch from which changes to set SO_PRIORITY were based.
+
+Alexander Dyuck
+Uncovering an out of bounds access of the netperf_output_source array.
\ No newline at end of file

Modified: trunk/src/nettest_omni.c
===================================================================
--- trunk/src/nettest_omni.c	2011-12-01 22:55:19 UTC (rev 509)
+++ trunk/src/nettest_omni.c	2011-12-02 18:46:32 UTC (rev 510)
@@ -2303,17 +2303,9 @@
 		 "Algorithm", "%s", remote_cong_control, 0,
 		 OMNI_WANT_REM_CONG);
 
+  set_output_elt(OUTPUT_END, "This", "Is", "The", "End", "%s",
+		 NULL, 0, 0);
 
-  netperf_output_source[i].output_name = OUTPUT_END;
-  netperf_output_source[i].line[0] = "This";
-  netperf_output_source[i].line[1] = "Is";
-  netperf_output_source[i].line[2] = "The";
-  netperf_output_source[i].line[3] = "End";
-  netperf_output_source[i].format = "%s";
-  netperf_output_source[i].display_value = NULL;
-  netperf_output_source[i].max_line_len = NETPERF_LINE_MAX(i);
-  netperf_output_source[i].tot_line_len = NETPERF_LINE_TOT(i);
-
 }
 
 void