[netperf-dev] [PATCH] fix sctp_rr_many test selection

[Rick Jones]

On Wed, 2011-04-20 at 13:13 +0800, Hushan Jia wrote:
> Hi,
> When I run sctp test suite, I found when specify -t SCTP_RR_MANY,
> netperf actuall run SCTP_STREAM_MANY test,
> after looking the code, I found there is a error in arguments
> processing code, the following patch should fix it.
> 
> # netperf -4 -H localhost -p 12865 -c -C -l 60 -t SCTP_RR_MANY -- -4 -r 1,1 -T 4
> SCTP 1-TO-MANY STREAM TEST from 0.0.0.0 (0.0.0.0) port 0 AF_INET to
> localhost.localdomain (127.0.0.1) port 0 AF_INET
> Recv   Send    Send                          Utilization       Service Demand
> Socket Socket  Message  Elapsed              Send     Recv     Send    Recv
> Size   Size    Size     Time     Throughput  local    remote   local   remote
> bytes  bytes   bytes    secs.    Trans   /s  % S      % S      us/KB   us/KB
> 
> Thanks & Regards,
> Hushan Jia
> 
> Index: trunk/src/netperf.c
> ===================================================================
> --- trunk/src/netperf.c	(revision 388)
> +++ trunk/src/netperf.c	(working copy)
> @@ -242,7 +242,7 @@
>      send_sctp_stream_1toMany(host_name);
>    }
>    else if (strcasecmp(test_name, "SCTP_RR_MANY") == 0) {
> -    send_sctp_stream_1toMany(host_name);
> +    send_sctp_rr_1toMany(host_name);
>    }
>  #endif

Nice catch.  I guess it shows that code isn't run all that often :)

happy benchmarking,

rick jones