[netperf-dev] netperf4 commit notice r110 - branches/glib_migration/src

raj at netperf.org raj at netperf.org
Wed Mar 29 16:31:34 PST 2006


Author: raj
Date: 2006-03-29 16:31:33 -0800 (Wed, 29 Mar 2006)
New Revision: 110

Modified:
   branches/glib_migration/src/netlib.c
   branches/glib_migration/src/netperf.c
   branches/glib_migration/src/nettest_bsd.c
Log:
Some valgrind cleanups on the netperf side.  There are still some puzzling
use of uninitialized messages from valgrind involving the report generation.


Modified: branches/glib_migration/src/netlib.c
===================================================================
--- branches/glib_migration/src/netlib.c	2006-03-29 23:00:17 UTC (rev 109)
+++ branches/glib_migration/src/netlib.c	2006-03-30 00:31:33 UTC (rev 110)
@@ -1290,6 +1290,7 @@
   if (debug) {
     fprintf(where,"map_la_to_lib returning '%s' from '%s'\n",lib,(char *)la);
   }
+  if (ld_library_path) free(ld_library_path);
 }
 
 GenReport
@@ -1321,7 +1322,7 @@
             (char *)la_file);
     fflush(where);
   }
- 
+  free(la_file);
   /* now we do the dlopen/gmodule magic */
 
 #ifdef WITH_GLIB
@@ -1402,6 +1403,7 @@
               (char *)la_file);
       fflush(where);
     }
+    free(la_file);
 #ifdef WITH_GLIB
     lib_handle = g_module_open((const gchar *)lib_file,0);
 #else
@@ -2685,6 +2687,7 @@
               *message);
       fflush(where);
     }
+    free(message_base);
     return(message_len);
   } else {
     if (debug) {

Modified: branches/glib_migration/src/netperf.c
===================================================================
--- branches/glib_migration/src/netperf.c	2006-03-29 23:00:17 UTC (rev 109)
+++ branches/glib_migration/src/netperf.c	2006-03-30 00:31:33 UTC (rev 110)
@@ -1194,6 +1194,8 @@
 
   NETPERF_DEBUG_EXIT(debug,where);
 
+  if (msg) xmlFreeNode(msg);
+
   return(test);
 }
 

Modified: branches/glib_migration/src/nettest_bsd.c
===================================================================
--- branches/glib_migration/src/nettest_bsd.c	2006-03-29 23:00:17 UTC (rev 109)
+++ branches/glib_migration/src/nettest_bsd.c	2006-03-30 00:31:33 UTC (rev 110)
@@ -2447,6 +2447,7 @@
     rd->utilization    = &(rd->trans_results[max_count]);
     rd->servdemand     = &(rd->utilization[max_count]);
     rd->run_time       = &(rd->servdemand[max_count]);
+    /* we should initialize result_confidence here? */
     rd->result_minimum = DBL_MAX;
     rd->result_maximum = DBL_MIN;
     rd->outfd          = outfd;



More information about the netperf-dev mailing list